Skip to content

fix NaN for functional-if-then-else #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Goober5000
Copy link
Contributor

Any NaN encountered in the evaluation of functional-if-then-else should be isolated to the branch on which it occurs. Fixes #6536.

Also improve some help text for clarity.

@Goober5000 Goober5000 added fix A fix for bugs, not-a-bugs, and/or regressions. sexps A feature or issue related to SEXPs labels Jan 19, 2025
Copy link
Member

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice turnaround and looks good to me

Any NaN encountered in the evaluation of functional-if-then-else should be isolated to the branch on which it occurs.  Fixes scp-fs2open#6536.

Also improve some help text for clarity.
@Goober5000 Goober5000 force-pushed the functional_if_then_else_fix branch from f5cef24 to a606ed7 Compare January 20, 2025 13:47
@Goober5000 Goober5000 merged commit f102cc3 into scp-fs2open:master Jan 22, 2025
16 checks passed
@Goober5000 Goober5000 deleted the functional_if_then_else_fix branch January 22, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for bugs, not-a-bugs, and/or regressions. sexps A feature or issue related to SEXPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functional-if-then-else returns NaN when either branch is NaN
2 participants